🐛 http dialer add socket config; sockopt.mark use uint32 #1264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems related to sockopt:
1.
sockopt.mark
config should acceptuint32
instead ofint32
Since some router (asus)'s iptables rule set the mark to be
0x80000000
(a negative number toint32
), specifying2147483648
in v2ray json config will result in error with loadingSocketConfig.Mark
.2. HTTP Dialer should accept socket config when dialing
Ever since 5279296, all other dialers except http dialer accepts socket config (http dialer only provides a
nil
toDialSystem
). It means outbounds with a http dialer will not set the socket mark even if specified in json config.This is a shocking behavior that will lead to quite a lot unaccountable issues when configuring transparent proxy with v2ray http/http2 outbound.